Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore tags from other branches #100

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

masonkatz
Copy link
Contributor

addresses issue #99

TestOffBranchTags creates a repo with a master and develop branch, and alternates commits on the branches. The resulting changelog from the master branch should only have those versions/commits.

This is only a test that shows the issue.

@masonkatz masonkatz changed the title test: ignore tags from other branches ignore tags from other branches Jul 17, 2022
@masonkatz
Copy link
Contributor Author

Added potential fix to pull request as independent commit.

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #100 (45bee1b) into master (4864bcc) will increase coverage by 2.98%.
The diff coverage is 65.51%.

❗ Current head 45bee1b differs from pull request most recent head 5dc9271. Consider uploading reports for the commit 5dc9271 to get more accurate results

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   22.24%   25.22%   +2.98%     
==========================================
  Files          15       15              
  Lines         625      654      +29     
==========================================
+ Hits          139      165      +26     
- Misses        466      467       +1     
- Partials       20       22       +2     
Impacted Files Coverage Δ
init.go 67.70% <65.51%> (+8.80%) ⬆️
add.go 77.61% <0.00%> (ø)
pkg/commands/format.go 0.00% <0.00%> (ø)
git.go 70.00% <0.00%> (+1.57%) ⬆️
files.go 38.88% <0.00%> (+7.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@masonkatz
Copy link
Contributor Author

The ci commit is a throw away. I just wanted to demonstrate this pull requests passes the ci checks.

@caarlos0
Copy link
Member

lgtm, can you rebase @masonkatz

cc/ @djgilcrease as well

Copy link
Collaborator

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djgilcrease
Copy link
Collaborator

Will never once the conflicts are resolved

TestOffBranchTags creates a repo with a master and develop branch, and
alternates commits on the branches. The resulting changelog from the
master branch should only have those versions/commits.
@masonkatz
Copy link
Contributor Author

Rebased

It looks like the ci is in flux right now -- see the linter failing on code outside of this commit.

@djgilcrease djgilcrease merged commit 4e00845 into goreleaser:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants